lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Jan 2020 17:33:07 +0200 From: Peter Ujfalusi <peter.ujfalusi@...com> To: Colin King <colin.king@...onical.com>, Vinod Koul <vkoul@...nel.org>, Dan Williams <dan.j.williams@...el.com>, Tony Lindgren <tony@...mide.com>, <dmaengine@...r.kernel.org> CC: <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH][next][V2] dmaengine: ti: omap-dma: don't allow a null od->plat pointer to be dereferenced Colin, On 09/01/2020 15.19, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > Currently when the call to dev_get_platdata returns null the driver issues > a warning and then later dereferences the null pointer. Avoid this issue > by returning -ENODEV errror rather when the platform data is null and > change the warning to an appropriate error message. Thank you for the update! Acked-by: Peter Ujfalusi <peter.ujfalusi@...com> > Addresses-Coverity: ("Dereference after null check") > Fixes: 211010aeb097 ("dmaengine: ti: omap-dma: Pass sdma auxdata to driver and use it") > Signed-off-by: Colin Ian King <colin.king@...onical.com> > --- > > V2: return -ENODEV and change warning to an error message as suggested by > Peter Ujfalusi. > --- > drivers/dma/ti/omap-dma.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/ti/omap-dma.c b/drivers/dma/ti/omap-dma.c > index fc8f7b2fc7b3..a93515015dce 100644 > --- a/drivers/dma/ti/omap-dma.c > +++ b/drivers/dma/ti/omap-dma.c > @@ -1658,8 +1658,10 @@ static int omap_dma_probe(struct platform_device *pdev) > if (conf) { > od->cfg = conf; > od->plat = dev_get_platdata(&pdev->dev); > - if (!od->plat) > - dev_warn(&pdev->dev, "no sdma auxdata needed?\n"); > + if (!od->plat) { > + dev_err(&pdev->dev, "omap_system_dma_plat_info is missing"); > + return -ENODEV; > + } > } else { > od->cfg = &default_cfg; > > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
Powered by blists - more mailing lists