linux-kernel - Re: [PATCH kunit] kunit: building kunit as a module breaks allmodconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb27a03b-1c3d-567b-caf3-7b0e4a039f6d@linuxfoundation.org>
Date:   Fri, 10 Jan 2020 14:39:10 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Alan Maguire <alan.maguire@...cle.com>, brendanhiggins@...gle.com,
        gregkh@...uxfoundation.org
Cc:     rafael@...nel.org, jmorris@...ei.org, serge@...lyn.com,
        knut.omang@...cle.com, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kselftest@...r.kernel.org, sfr@...b.auug.org.au,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH kunit] kunit: building kunit as a module breaks
 allmodconfig

Hi Alan,

On 1/10/20 4:49 AM, Alan Maguire wrote:
> kunit tests that do not support module build should depend
> on KUNIT=y rather than just KUNIT in Kconfig, otherwise
> they will trigger compilation errors for "make allmodconfig"
> builds.
> 
> Fixes: 9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
> Signed-off-by: Alan Maguire <alan.maguire@...cle.com>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>

Thanks for fixing this quickly. For future reference, Signed-off-by
should be last. I fixed it and applied the patch.

thanks,
-- Shuah