linux-kernel - Re: [PATCH 0/6] dt-bindings: display: Update few panel bindings with YAML

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200110220548.GB29600@ravnborg.org>
Date:   Fri, 10 Jan 2020 23:05:48 +0100
From:   Sam Ravnborg <sam@...nborg.org>
To:     Jagan Teki <jagan@...rulasolutions.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Mark Rutland <mark.rutland@....com>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-amarula <linux-amarula@...rulasolutions.com>
Subject: Re: [PATCH 0/6] dt-bindings: display: Update few panel bindings with
 YAML

Hi Jagan.

On Mon, Jan 06, 2020 at 03:41:40PM +0530, Jagan Teki wrote:
> Hi Sam,
> 
> On Sat, Jan 4, 2020 at 8:47 PM Sam Ravnborg <sam@...nborg.org> wrote:
> >
> > Hi Jagan.
> > On Wed, Jan 01, 2020 at 04:54:38PM +0530, Jagan Teki wrote:
> > > These panel bindings are owned by me, so updated all of them into
> > > YAML DT schema.
> > >
> > > Any inputs?
> > Thanks for doing the conversion.
> >
> > dt_binding_check was not happy:
> > Documentation/devicetree/bindings/display/panel/rocktech,rk070er9427.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+'
> >   DTC     Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml
> >   CHECK   Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml
> > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: 'backlight', 'port' do not match any of the regexes: 'pinctrl-[0-9]+'
> > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: Additional items are not allowed ('simple-panel' was unexpected)
> > Documentation/devicetree/bindings/display/panel/friendlyarm,hd702e.example.dt.yaml: panel: compatible: ['friendlyarm,hd702e', 'simple-panel'] is too long
> >   DTC     Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dt.yaml
> > Error: Documentation/devicetree/bindings/display/panel/sitronix,st7701.example.dts:22.42-43 syntax error
> > FATAL ERROR: Unable to parse input tree
> >
> > Please fix and check the bindings using dt_binding_check before
> > resubmit.
> >
> > I had to install libyaml-dev (as least I recall this was the name)
> > before dt_binding_check worked OK for me.
> 
> I did check dt_binfing_check with this series. Here is the complete
> build log and you can see the panels related to this series are
> checked fine. Let me know if I miss anything here?

Due to other errors you never reached the poart that checks the example.
I use the following to focus on a single binding:

(from my script, but you get the idea)

domake ${arch} ${config} dt_binding_check DT_SCHEMA_FILES=${bindings}/display/panel/feixin,k101-im2ba02.yaml

In this way I can ignore all the bindings that otherwise fails.

Note: I sometimes have to clean my ouput directory to force that the
examples are tested.

It is also a good idea to introduce errors on purpose in the example, in
this way you can check that they are tested.

	Sam