linux-kernel - Re: [PATCH v2 1/2] scsi: ufs: pass device information to apply_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1578640121.17435.7.camel@mtkswgap22>
Date:   Fri, 10 Jan 2020 15:08:41 +0800
From:   Stanley Chu <stanley.chu@...iatek.com>
To:     "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     <linux-scsi@...r.kernel.org>, <andy.teng@...iatek.com>,
        <jejb@...ux.ibm.com>, <chun-hung.wu@...iatek.com>,
        <kuohong.wang@...iatek.com>, <linux-kernel@...r.kernel.org>,
        <avri.altman@....com>, <cang@...eaurora.org>,
        <linux-mediatek@...ts.infradead.org>, <peter.wang@...iatek.com>,
        <alim.akhtar@...sung.com>, <matthias.bgg@...il.com>,
        <asutoshd@...eaurora.org>, <bvanassche@....org>,
        <linux-arm-kernel@...ts.infradead.org>, <beanhuo@...ron.com>
Subject: Re: [PATCH v2 1/2] scsi: ufs: pass device information to
 apply_dev_quirks

Hi Martin,

On Fri, 2020-01-10 at 01:25 -0500, Martin K. Petersen wrote:
> Stanley,
> 
> > Pass UFS device information to vendor-specific variant callback
> > "apply_dev_quirks" because some platform vendors need to know such
> > information to apply special handlings or quirks in specific devices.
> 
> This doesn't compile. You missed adding the additional argument to one
> caller of ufshcd_tune_unipro_params().
> 

Sorry for this. I'll fix it in next version and try to separate vendor's
implementation and common driver to different commits if this is the
root cause of compile issue.

Thanks.
Stanley