linux-kernel - Re: [PATCH 1/2] regulator: ab8500: Remove AB8505 USB regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Jan 2020 09:16:43 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Sasha Levin <sashal@...nel.org>,
        Stephan Gerhold <stephan@...hold.net>,
        Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux- stable <stable@...r.kernel.org>
Subject: Re: [PATCH 1/2] regulator: ab8500: Remove AB8505 USB regulator

On Fri, Jan 10, 2020 at 01:32:57PM +0530, Naresh Kamboju wrote:
> On Thu, 7 Nov 2019 at 13:32, Linus Walleij <linus.walleij@...aro.org> wrote:
> >
> > On Wed, Nov 6, 2019 at 6:33 PM Stephan Gerhold <stephan@...hold.net> wrote:
> >
> > > The USB regulator was removed for AB8500 in
> > > commit 41a06aa738ad ("regulator: ab8500: Remove USB regulator").
> > > It was then added for AB8505 in
> > > commit 547f384f33db ("regulator: ab8500: add support for ab8505").
> > >
> 
> Stable-rc 4.4 branch arm build failed due to this error.
> 
> arch/arm/mach-ux500/board-mop500-regulators.c:957:3: error:
> 'AB8505_LDO_USB' undeclared here (not in a function); did you mean
> 'AB9540_LDO_USB'?
>   [AB8505_LDO_USB] = {
>    ^~~~~~~~~~~~~~
>    AB9540_LDO_USB
> arch/arm/mach-ux500/board-mop500-regulators.c:957:3: error: array
> index in initializer not of integer type
> arch/arm/mach-ux500/board-mop500-regulators.c:957:3: note: (near
> initialization for 'ab8505_regulators')
> 
> Full build log,
> https://ci.linaro.org/view/lkft/job/openembedded-lkft-linux-stable-rc-4.4/DISTRO=lkft,MACHINE=am57xx-evm,label=docker-lkft/703/consoleText
> 

Good catch, I'll go drop this patch from the 4.4.y queue now, thanks.

greg k-h