linux-kernel - Re: [PATCH -next] nvmem: fix a 'makes pointer from integer without a cast' build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mc3hkzJ+Xk_nD3m3uv4_pTUnNaW-0s6Vh3osXCzYBH7fA@mail.gmail.com>
Date:   Fri, 10 Jan 2020 09:26:11 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Khouloud Touil <ktouil@...libre.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH -next] nvmem: fix a 'makes pointer from integer without a
 cast' build warning

pt., 10 sty 2020 o 09:24 Bartosz Golaszewski <brgl@...ev.pl> napisał(a):
>
> From: Bartosz Golaszewski <bgolaszewski@...libre.com>
>
> nvmem_register() returns a pointer, not a long int. Use ERR_CAST() to
> cast the struct gpio_desc pointer to struct nvmem_device.
>
> Reported-by: kbuild test robot <lkp@...el.com>
> Fixes: 2a127da461a9 ("nvmem: add support for the write-protect pin")
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> ---
>  drivers/nvmem/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
> index 3e1c94c4eee8..408ce702347e 100644
> --- a/drivers/nvmem/core.c
> +++ b/drivers/nvmem/core.c
> @@ -351,7 +351,7 @@ struct nvmem_device *nvmem_register(const struct nvmem_config *config)
>                 nvmem->wp_gpio = gpiod_get_optional(config->dev, "wp",
>                                                     GPIOD_OUT_HIGH);
>         if (IS_ERR(nvmem->wp_gpio))
> -               return PTR_ERR(nvmem->wp_gpio);
> +               return ERR_CAST(nvmem->wp_gpio);
>
>
>         kref_init(&nvmem->refcnt);
> --
> 2.23.0
>

Srinivas: this fixes a bug introduced in a patch I took through the
at24 tree. With your ack I'll apply it as a follow-up.

Bart