linux-kernel - Re: [PATCH -next] drm/mgag200: Fix typo in parameter description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce1a17c8-2af9-a449-16d5-36ddfd7a976e@suse.de>
Date:   Fri, 10 Jan 2020 09:28:07 +0100
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Dave Airlie <airlied@...hat.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Thomas Gleixner <tglx@...utronix.de>,
        Gerd Hoffmann <kraxel@...hat.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Kate Stewart <kstewart@...uxfoundation.org>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] drm/mgag200: Fix typo in parameter description

Hi

Am 10.01.20 um 02:25 schrieb Wei Yongjun:
> Fix typo in parameter description.

As Dan said, please mention that it's about a module parameter. The
current commit message appears to refer to a function's parameter.

With the commit message fixed, you can add

Reviewed-by: Thomas Zimemrmann <tzimmermann@...e.de>

Thanks for fixing this bug.

Best regards
Thomas

> 
> Fixes: 3cacb2086e41 ("drm/mgag200: Add module parameter to pin all buffers at offset 0")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
> index 7a5bad2f57d7..2236f8ef20a4 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_drv.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
> @@ -28,7 +28,7 @@ MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
>  module_param_named(modeset, mgag200_modeset, int, 0400);
>  
>  int mgag200_hw_bug_no_startadd = -1;
> -MODULE_PARM_DESC(modeset, "HW does not interpret scanout-buffer start address correctly");
> +MODULE_PARM_DESC(hw_bug_no_startadd, "HW does not interpret scanout-buffer start address correctly");
>  module_param_named(hw_bug_no_startadd, mgag200_hw_bug_no_startadd, int, 0400);
>  
>  static struct drm_driver driver;
> 
> 
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer



Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)