lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jan 2020 16:46:21 +0800 From: Zhenzhong Duan <zhenzhong.duan@...il.com> To: Thomas Gleixner <tglx@...utronix.de> Cc: linux-kernel@...r.kernel.org, x86@...nel.org, Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...e.de>, "H. Peter Anvin" <hpa@...or.com>, Chao Fan <fanc.fnst@...fujitsu.com>, Dave Hansen <dave.hansen@...ux.intel.com>, "Rafael J. Wysocki" <rafael.j.wysocki@...el.com> Subject: Re: [PATCH v2] x86/boot/KASLR: Fix unused variable warning On Fri, Jan 10, 2020 at 5:00 AM Thomas Gleixner <tglx@...utronix.de> wrote: > > Zhenzhong Duan <zhenzhong.duan@...il.com> writes: > > > Local variable 'i' is referenced only when CONFIG_MEMORY_HOTREMOVE and > > CONFIG_ACPI are defined, but definition of variable 'i' is out of guard. > > If any of the two macros is undefined, below warning triggers during > > build, fix it by moving 'i' in the guard. > > > > arch/x86/boot/compressed/kaslr.c:698:6: warning: unused variable āiā [-Wunused-variable] > > > > Also use true/false instead of 1/0 for boolean return. > > No. This is not the scope of the unused variable issue. This want's to > be a separate patch. I'm trying to combine trivial changes into one, so you maintainers don't mind to pick two trivial patches? :) Regards Zhenzhong
Powered by blists - more mailing lists