linux-kernel - Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bbd8f47-fe68-574c-cbe9-bcc680dd4c84@gmail.com>
Date:   Fri, 10 Jan 2020 11:09:56 +0100
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     Nicolas Boichat <drinkcat@...omium.org>,
        Yong Liang <yong.liang@...iatek.com>
Cc:     linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Devicetree List <devicetree@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>, wim@...ux-watchdog.org,
        linux@...ck-us.net, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi



On 08/01/2020 10:14, Nicolas Boichat wrote:
> On Wed, Jan 8, 2020 at 4:56 PM Nicolas Boichat <drinkcat@...omium.org> wrote:
>>
>> minor nit, s/amr64/arm64/ in the commit title.
>>
>> On Fri, Dec 27, 2019 at 10:15 PM Yong Liang <yong.liang@...iatek.com> wrote:
>>>
>>> From: "yong.liang" <yong.liang@...iatek.com>
>>>
>>> 1. Include mt8183-reset.h and add reset-cells in infracfg
>>> in dtsi file
> 
> Err, wait, doesn't this depend on
> http://lists.infradead.org/pipermail/linux-mediatek/2020-January/026170.html
> ?
> 

That's all a bit confusing, I thought we are fine to add the reset cells to
infracfg as we have the resets defined in
64ebb57a3df6 ("clk: reset: Modify reset-controller driver")

That's why I took this part from:
https://lore.kernel.org/linux-mediatek/20191226093930.22413-1-yong.liang@mediatek.com/

Please let me know if I'm wrong and I'll drop it.

Regards,
Matthias

>>> 2. Add watchdog device node
> 
> Can we have a patch with just this change instead, since you're
> sending the binding with it.
> 
>>>
>>> Signed-off-by: yong.liang <yong.liang@...iatek.com>
>>
>> Tested-by: Nicolas Boichat <drinkcat@...omium.org>
>>
>>> ---
>>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
>>>  1 file changed, 8 insertions(+)
>>> [snip]