linux-kernel - Re: [PATCH] platform/chrome: wilco_ec: Fix keyboard backlight probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b6cfdfee-7e1f-117d-cb42-2d067ebd3807@collabora.com>
Date:   Fri, 10 Jan 2020 11:46:08 +0100
From:   Enric Balletbo i Serra <enric.balletbo@...labora.com>
To:     Daniel Campello <campello@...omium.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Nick Crews <ncrews@...omium.org>,
        Benson Leung <bleung@...omium.org>
Subject: Re: [PATCH] platform/chrome: wilco_ec: Fix keyboard backlight probing

Hi Daniel,
On 8/1/20 16:59, Daniel Campello wrote:
> Hi Enric,
> 
> On Wed, Jan 08, 2020 at 11:38:58AM +0100, Enric Balletbo i Serra wrote:
>> Hi Daniel,
>>
>> Many thanks for sending the patch upstream.
>>
>> On 7/1/20 19:24, Daniel Campello wrote:
>>> The EC on the Wilco platform responds with 0xFF to commands related to
>>> the keyboard backlight on the absence of a keyboard backlight module.
>>> This change allows the EC driver to continue loading even if the
>>> backlight module is not present.
>>>
>>
>> Could you explain a bit more which is the problem you're trying to solve? I am
>> not sure I understand it, isn't the kbbl_exist call for that purpose? (in
>> absence of the keyboard backligh module just don't init the device?)
> 
> kbbl_exists is intended to return a bool based on response.status !=
> 0xFF. Without this patch kbbl_exists will fail and return an -EIO
> error on any value of response.status
> 

Thanks for the explanation I understand now what is happening. I added the Fixed
tag and queued as a fix for chrome-platform-5.5

Thanks,
 Enric

>>
>> Thanks,
>>  Enric
>>