linux-kernel - Re: [PATCH v1] mfd: syscon: Switch to use devm_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Jan 2020 14:02:37 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Lee Jones <lee.jones@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] mfd: syscon: Switch to use devm_ioremap_resource()

On Fri, Jan 10, 2020 at 12:40 PM Arnd Bergmann <arnd@...db.de> wrote:
>
> On Fri, Jan 10, 2020 at 11:15 AM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> >
> > Instead of checking resource pointer for being NULL and
> > report some not very standard error codes in this case,
> > switch to devm_ioremap_resource() API.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>
> With syscon, I'm worried there are users that map the same region in another
> driver, so doing devm_ioremap_resource() here will make another driver fail.
>
> Maybe just change the error code and add a comment warning about that
> instead?

Oh, yes, you are right.

Thanks for review.

-- 
With Best Regards,
Andy Shevchenko