linux-kernel - Re: [PATCH] iwlwifi: fix build warnings with format string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87muavsb8d.fsf@codeaurora.org>
Date:   Fri, 10 Jan 2020 15:16:18 +0200
From:   Kalle Valo <kvalo@...eaurora.org>
To:     unlisted-recipients:; (no To-header on input)
Cc:     linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        linux-next@...r.kernel.org, sfr@...b.auug.org.au,
        Stanislaw Gruszka <stf_xl@...pl>,
        linux-wireless@...r.kernel.org
Subject: Re: [PATCH] iwlwifi: fix build warnings with format string

(please cc linux-wireless on all wireless patches)

Akinobu Mita <akinobu.mita@...il.com> writes:

> This fixes build warnings introduced by commit "iwlegacy: use
> <linux/units.h> helpers" (iwlegacy-use-linux-unitsh-helpers.patch in -mm)
>
> The format '%d' has to be changed to '%ld' because the return type of
> kelvin_to_celsius() is 'long'.
>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Link: https://lore.kernel.org/r/20200106171452.201c3b4c@canb.auug.org.au
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: Stanislaw Gruszka <stf_xl@...pl>
> Signed-off-by: Akinobu Mita <akinobu.mita@...il.com>

I don't know what's Andrew's workflow, but shouldn't the original patch
be fixed instead?

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches