lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 10 Jan 2020 14:58:49 +0000 From: Russell King - ARM Linux admin <linux@...linux.org.uk> To: Andre Przywara <andre.przywara@....com> Cc: "David S . Miller" <davem@...emloft.net>, Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>, Robert Hancock <hancock@...systems.ca>, netdev@...r.kernel.org, Michal Simek <michal.simek@...inx.com>, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 07/14] net: axienet: Fix SGMII support On Fri, Jan 10, 2020 at 11:54:08AM +0000, Andre Przywara wrote: > With SGMII, the MAC and the PHY can negotiate the link speed between > themselves, without the host needing to mediate between them. > Linux recognises this, and will call phylink's mac_config with the speed > member set to SPEED_UNKNOWN (-1). I wonder whether you have read the documentation for the phylink mac_config() method (if not, please read it, it contains some very important information about what mac_config() should do.) When operating in SGMII in-band mode, state->speed and state->duplex are not actually valid. You'll probably want to submit a better patch after reading the documentation. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up
Powered by blists - more mailing lists