linux-kernel - Re: [PATCH 3.16 62/63] mwifiex: fix possible heap overflow in mwifiex_process_country

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <06888d5dc85085a47ea1465167c604fd9fec5210.camel@decadent.org.uk>
Date:   Fri, 10 Jan 2020 16:01:35 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Salvatore Bonaccorso <carnil@...ian.org>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        akpm@...ux-foundation.org, Denis Kirjanov <kda@...ux-powerpc.org>,
        huangwen <huangwenabc@...il.com>,
        Ganapathi Bhat <gbhat@...vell.com>,
        Kalle Valo <kvalo@...eaurora.org>,
        Brian Norris <briannorris@...omium.org>
Subject: Re: [PATCH 3.16 62/63] mwifiex: fix possible heap overflow in
 mwifiex_process_country_ie()

On Thu, 2020-01-09 at 13:12 +0100, Salvatore Bonaccorso wrote:
> Hi Ben,
> 
> On Wed, Jan 08, 2020 at 07:44:00PM +0000, Ben Hutchings wrote:
> > 3.16.81-rc1 review patch.  If anyone has any objections, please let me know.
> > 
> > ------------------
> > 
> > From: Ganapathi Bhat <gbhat@...vell.com>
> > 
> > commit 3d94a4a8373bf5f45cf5f939e88b8354dbf2311b upstream.
[...]
> Brian Norris noted that this commit has unbalanced locking and
> submitted a followup as per:
> 
> https://lkml.kernel.org/linux-wireless/20200106224212.189763-1-briannorris@chromium.org/T/#u
> https://patchwork.kernel.org/patch/11320227/

Right, but is the new behaviour (possible wrong preemption count)
actually worse than the old behaviour (possible heap buffer overflow)?

I think we are better off applying this now and adding that fix once
it's upstream.

Ben.

-- 
Ben Hutchings
Every program is either trivial or else contains at least one bug



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)