linux-kernel - Re: [PATCH] net/x25: fix nonblocking connect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200109.184008.1039668214219996565.davem@davemloft.net>
Date:   Thu, 09 Jan 2020 18:40:08 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ms@....tdt.de
Cc:     arnd@...db.de, andrew.hendry@...il.com, edumazet@...gle.com,
        gregkh@...uxfoundation.org, tglx@...utronix.de,
        linux-x25@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        syzbot+429c200ffc8772bfe070@...kaller.appspotmail.com,
        syzbot+eec0c87f31a7c3b66f7b@...kaller.appspotmail.com
Subject: Re: [PATCH] net/x25: fix nonblocking connect

From: Martin Schiller <ms@....tdt.de>
Date: Thu,  9 Jan 2020 07:31:14 +0100

> This patch fixes 2 issues in x25_connect():
> 
> 1. It makes absolutely no sense to reset the neighbour and the
> connection state after a (successful) nonblocking call of x25_connect.
> This prevents any connection from being established, since the response
> (call accept) cannot be processed.
> 
> 2. Any further calls to x25_connect() while a call is pending should
> simply return, instead of creating new Call Request (on different
> logical channels).
> 
> This patch should also fix the "KASAN: null-ptr-deref Write in
> x25_connect" and "BUG: unable to handle kernel NULL pointer dereference
> in x25_connect" bugs reported by syzbot.
> 
> Signed-off-by: Martin Schiller <ms@....tdt.de>
> Reported-by: syzbot+429c200ffc8772bfe070@...kaller.appspotmail.com
> Reported-by: syzbot+eec0c87f31a7c3b66f7b@...kaller.appspotmail.com

Applied and queued up for -stable, thanks.