linux-kernel - Re: [PATCH v3] coccinelle: semantic patch to check for inappropriate do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91abb141-57b8-7659-25ec-8080e290d846@web.de>
Date:   Fri, 10 Jan 2020 17:35:21 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wen Yang <wenyang@...ux.alibaba.com>, cocci@...teme.lip6.fr,
        kernel-janitors@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Matthias Männich <maennich@...gle.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v3] coccinelle: semantic patch to check for inappropriate
 do_div() calls

> +@...tialize:python@
…
> +def filter_out_safe_constants(str):
…
> +def construct_warnings(str, suggested_fun):

* I suggest once more to adjust the dependency specifications for the usage
  of these functions by SmPL rules.

* Can the local variable “msg” be omitted?


> +coccilib.org.print_todo(p[0], construct_warnings("div64_ul"))

I suggest again to move the prefix “div64_” into the string literal
of the function implementation.


The SmPL code for two disjunctions could become shorter.

Regards,
Markus