linux-kernel - Re: [PATCH][next] ath11k: avoid null pointer dereference when pointer band is null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <05d5d54e035e4d69ad4ffb4a835a495a@huawei.com>
Date:   Sat, 11 Jan 2020 09:50:12 +0000
From:   linmiaohe <linmiaohe@...wei.com>
To:     Colin King <colin.king@...onical.com>
CC:     Kalle Valo <kvalo@...eaurora.org>,
        "David S . Miller" <davem@...emloft.net>,
        John Crispin <john@...ozen.org>,
        Shashidhar Lakkavalli <slakkavalli@...to.com>,
        "ath11k@...ts.infradead.org" <ath11k@...ts.infradead.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][next] ath11k: avoid null pointer dereference when pointer
 band is null


Colin Ian King <colin.king@...onical.com> wrote：
>From: Colin Ian King <colin.king@...onical.com>
>
>In the unlikely event that cap->supported_bands has neither WMI_HOST_WLAN_2G_CAP set or WMI_HOST_WLAN_5G_CAP set then pointer band is null and a null dereference occurs when assigning
>band->n_iftype_data.  Move the assignment to the if blocks to
>avoid this.  Cleans up static analysis warnings.
>
>Addresses-Coverity: ("Explicit null dereference")
>Fixes: 9f056ed8ee01 ("ath11k: add HE support")
>Signed-off-by: Colin Ian King <colin.king@...onical.com>
>---
> drivers/net/wireless/ath/ath11k/mac.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)

It looks fine for me. Thanks.
Reviewed-by: Miaohe Lin <linmiaohe@...wei.com>