linux-kernel - Re: [PATCH] input: max77650-onkey: add of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Mcu-oNC009JLkNSDrKjg_ygb63ZTnrmu+8NwNZrOVsEZQ@mail.gmail.com>
Date:   Sat, 11 Jan 2020 11:22:55 +0100
From:   Bartosz Golaszewski <brgl@...ev.pl>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Input <linux-input@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH] input: max77650-onkey: add of_match table

pt., 10 sty 2020 o 19:28 Dmitry Torokhov <dmitry.torokhov@...il.com> napisał(a):
>
> On Tue, Dec 10, 2019 at 11:07:53AM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> >
> > We need the of_match table if we want to use the compatible string in
> > the pmic's child node and get the onkey driver loaded automatically.
>
> Do we really need of_match table or adding
>

Not really. Technically not anyway but we merged bindings that define
it (at the time I didn't know any better) and seems we're stuck with
it. Please see the discussion below a similar patch for regulator
subsystem[1].

> MODULE_ALIAS("platform:max77650-onkey");
>

This is already in there, but if someone defines the compatible in the
device tree as per bindings, the module won't be loaded despite the
MODULE_ALIAS() definition.

> will work as well?
>
> In general, do we ever instantiate onkey portion from device tree? Or
> is it always an MFD cell that is instantiated unconditionally?
>

Bart

[1] https://lkml.org/lkml/2019/12/10/271