linux-kernel - Re: [PATCH v1 1/4] kasan: introduce set_pmd_early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202001111016.0FiJOWlF%lkp@intel.com>
Date:   Sat, 11 Jan 2020 13:21:14 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Sergey Dyasli <sergey.dyasli@...rix.com>
Cc:     kbuild-all@...ts.01.org, xen-devel@...ts.xen.org,
        kasan-dev@...glegroups.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org,
        Andrey Ryabinin <aryabinin@...tuozzo.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        George Dunlap <george.dunlap@...rix.com>,
        Ross Lagerwall <ross.lagerwall@...rix.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Sergey Dyasli <sergey.dyasli@...rix.com>
Subject: Re: [PATCH v1 1/4] kasan: introduce set_pmd_early_shadow()

Hi Sergey,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]
[also build test ERROR on net/master linus/master v5.5-rc5 next-20200109]
[cannot apply to xen-tip/linux-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Sergey-Dyasli/basic-KASAN-support-for-Xen-PV-domains/20200110-042623
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 4a4a52d49d11f5c4a0df8b9806c8c5563801f753
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=s390 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   mm//kasan/init.c: In function 'set_pmd_early_shadow':
>> mm//kasan/init.c:90:3: error: implicit declaration of function 'set_pmd'; did you mean 'get_pid'? [-Werror=implicit-function-declaration]
      set_pmd(pmd, __pmd(__pa(early_shadow) | _PAGE_TABLE));
      ^~~~~~~
      get_pid
   In file included from arch/s390/include/asm/thread_info.h:26:0,
                    from include/linux/thread_info.h:38,
                    from arch/s390/include/asm/preempt.h:6,
                    from include/linux/preempt.h:78,
                    from include/linux/spinlock.h:51,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:6,
                    from include/linux/mm.h:10,
                    from include/linux/memblock.h:13,
                    from mm//kasan/init.c:14:
   mm//kasan/init.c:90:43: error: '_PAGE_TABLE' undeclared (first use in this function); did you mean 'NR_PAGETABLE'?
      set_pmd(pmd, __pmd(__pa(early_shadow) | _PAGE_TABLE));
                                              ^
   arch/s390/include/asm/page.h:96:37: note: in definition of macro '__pmd'
    #define __pmd(x)        ((pmd_t) { (x) } )
                                        ^
   mm//kasan/init.c:90:43: note: each undeclared identifier is reported only once for each function it appears in
      set_pmd(pmd, __pmd(__pa(early_shadow) | _PAGE_TABLE));
                                              ^
   arch/s390/include/asm/page.h:96:37: note: in definition of macro '__pmd'
    #define __pmd(x)        ((pmd_t) { (x) } )
                                        ^
   cc1: some warnings being treated as errors

vim +90 mm//kasan/init.c

    83	
    84	static inline void set_pmd_early_shadow(pmd_t *pmd)
    85	{
    86		static bool pmd_populated = false;
    87		pte_t *early_shadow = lm_alias(kasan_early_shadow_pte);
    88	
    89		if (likely(pmd_populated)) {
  > 90			set_pmd(pmd, __pmd(__pa(early_shadow) | _PAGE_TABLE));
    91		} else {
    92			pmd_populate_kernel(&init_mm, pmd, early_shadow);
    93			pmd_populated = true;
    94		}
    95	}
    96	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (57223 bytes)