linux-kernel - Re: [PATCH] iio: humidity: dht11 remove TODO since it doesn't make sense

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 11 Jan 2020 11:55:29 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Kent Gustavsson <kent@...oris.se>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Richard Fontana <rfontana@...hat.com>,
        Shobhit Kukreti <shobhitkukreti@...il.com>,
        Arnd Bergmann <arnd@...db.de>,
        Allison Randal <allison@...utok.net>,
        "Jason A. Donenfeld" <Jason@...c4.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: humidity: dht11 remove TODO since it doesn't make
 sense

On Sat,  4 Jan 2020 19:19:29 +0100
Kent Gustavsson <kent@...oris.se> wrote:

> DHT11 isn't addressable and will trigger temperature measurement on any
> data sent on the bus.
> 
> Signed-off-by: Kent Gustavsson <kent@...oris.se>
Applied.

Thanks,

Jonathan

> ---
>  drivers/iio/humidity/dht11.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/humidity/dht11.c b/drivers/iio/humidity/dht11.c
> index b459600e1a33..d05c6fdb758b 100644
> --- a/drivers/iio/humidity/dht11.c
> +++ b/drivers/iio/humidity/dht11.c
> @@ -174,7 +174,6 @@ static irqreturn_t dht11_handle_irq(int irq, void *data)
>  	struct iio_dev *iio = data;
>  	struct dht11 *dht11 = iio_priv(iio);
>  
> -	/* TODO: Consider making the handler safe for IRQ sharing */
>  	if (dht11->num_edges < DHT11_EDGES_PER_READ && dht11->num_edges >= 0) {
>  		dht11->edges[dht11->num_edges].ts = ktime_get_boottime_ns();
>  		dht11->edges[dht11->num_edges++].value =