linux-kernel - Re: [PATCH] KVM: remove unused guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <668e6bcb-89b9-7256-5492-274da5ea5836@linux.alibaba.com>
Date:   Sat, 11 Jan 2020 21:21:30 +0800
From:   Alex Shi <alex.shi@...ux.alibaba.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...nel.org>,
        Frederic Weisbecker <frederic@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] KVM: remove unused guest_enter/exit



在 2020/1/11 下午7:32, Paolo Bonzini 写道:
> On 10/01/20 04:13, Alex Shi wrote:
>> After commit 6edaa5307f3f ("KVM: remove kvm_guest_enter/exit wrappers")
>> no one uses guest_enter/exit anymore.
>>
>> So better to remove them to simplify code and reduced a bit of object
>> size.
> 
> There is no reduction in object size, since these are inlines.  But PPC
> still uses them.
> 
> Paolo
> 

Thanks a lot Paolo. It's my fault to ommit the guest_exit checking.
Yes, guest_exit is still in using. but guest_enter isn't. no one use it. 

So how about this?

Thanks
Alex

---

>From 5770c6b8b43adc1e26ecfe696488ccc01896ebfd Mon Sep 17 00:00:00 2001
From: Alex Shi <alex.shi@...ux.alibaba.com>
Date: Sat, 11 Jan 2020 20:25:45 +0800
Subject: [PATCH] KVM: remove unused guest_enter

No one uses guest_enter anymore, so better to remove it.

Signed-off-by: Alex Shi <alex.shi@...ux.alibaba.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>
Cc: Peter Zijlstra <peterz@...radead.org>
Cc: Ingo Molnar <mingo@...nel.org>
Cc: Frederic Weisbecker <frederic@...nel.org>
Cc: linux-kernel@...r.kernel.org
---
 include/linux/context_tracking.h | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/include/linux/context_tracking.h b/include/linux/context_tracking.h
index 64ec82851aa3..8150f5ac176c 100644
--- a/include/linux/context_tracking.h
+++ b/include/linux/context_tracking.h
@@ -154,15 +154,6 @@ static inline void guest_exit_irqoff(void)
 }
 #endif /* CONFIG_VIRT_CPU_ACCOUNTING_GEN */
 
-static inline void guest_enter(void)
-{
-	unsigned long flags;
-
-	local_irq_save(flags);
-	guest_enter_irqoff();
-	local_irq_restore(flags);
-}
-
 static inline void guest_exit(void)
 {
 	unsigned long flags;
-- 
1.8.3.1