linux-kernel - Re: [Patch v7 4/7] sched/fair: Enable periodic update of average thermal pressure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Jan 2020 02:27:56 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Thara Gopinath <thara.gopinath@...aro.org>
Cc:     kbuild-all@...ts.01.org, mingo@...hat.com, peterz@...radead.org,
        ionela.voinescu@....com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, rui.zhang@...el.com, qperret@...gle.com,
        daniel.lezcano@...aro.org, viresh.kumar@...aro.org,
        linux-kernel@...r.kernel.org, amit.kachhap@...il.com,
        javi.merino@...nel.org, amit.kucheria@...durent.com
Subject: Re: [Patch v7 4/7] sched/fair: Enable periodic update of average
 thermal pressure

Hi Thara,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20200110]
[also build test ERROR on v5.5-rc5]
[cannot apply to tip/sched/core tip/perf/core arm/for-next arm64/for-next/core driver-core/driver-core-testing linus/master v5.5-rc5 v5.5-rc4 v5.5-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Thara-Gopinath/Introduce-Thermal-Pressure/20200112-000559
base:    6c09d7dbb7d366122d0218bc7487e0a1e6cca6ed
config: sh-randconfig-a001-20200112 (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/sched/fair.c: In function 'task_tick_fair':
>> kernel/sched/fair.c:10308:2: error: implicit declaration of function 'update_thermal_load_avg'; did you mean 'update_thermal_rq_load_avg'? [-Werror=implicit-function-declaration]
     update_thermal_load_avg(rq_clock_task(rq), rq, thermal_pressure);
     ^~~~~~~~~~~~~~~~~~~~~~~
     update_thermal_rq_load_avg
   cc1: some warnings being treated as errors

vim +10308 kernel/sched/fair.c

 10283	
 10284	/*
 10285	 * scheduler tick hitting a task of our scheduling class.
 10286	 *
 10287	 * NOTE: This function can be called remotely by the tick offload that
 10288	 * goes along full dynticks. Therefore no local assumption can be made
 10289	 * and everything must be accessed through the @rq and @curr passed in
 10290	 * parameters.
 10291	 */
 10292	static void task_tick_fair(struct rq *rq, struct task_struct *curr, int queued)
 10293	{
 10294		struct cfs_rq *cfs_rq;
 10295		struct sched_entity *se = &curr->se;
 10296		unsigned long thermal_pressure = arch_cpu_thermal_pressure(cpu_of(rq));
 10297	
 10298		for_each_sched_entity(se) {
 10299			cfs_rq = cfs_rq_of(se);
 10300			entity_tick(cfs_rq, se, queued);
 10301		}
 10302	
 10303		if (static_branch_unlikely(&sched_numa_balancing))
 10304			task_tick_numa(rq, curr);
 10305	
 10306		update_misfit_status(curr, rq);
 10307		update_overutilized_status(task_rq(curr));
 10308		update_thermal_load_avg(rq_clock_task(rq), rq, thermal_pressure);
 10309	}
 10310	

---
0-DAY kernel test infrastructure                 Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (30777 bytes)