linux-kernel - Re: [PATCH] kconfig: ignore temporary generated files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAT8ZgeMRgm1jjnj6P+UPWF-uuJtJj8hmgCsx6JRD2h5rg@mail.gmail.com>
Date:   Sat, 11 Jan 2020 16:18:01 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Bartosz Golaszewski <bgolaszewski@...libre.com>
Cc:     Bartosz Golaszewski <brgl@...ev.pl>,
        Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kconfig: ignore temporary generated files

On Fri, Jan 10, 2020 at 1:38 AM Bartosz Golaszewski
<bgolaszewski@...libre.com> wrote:
>
> czw., 9 sty 2020 o 17:36 Masahiro Yamada <masahiroy@...nel.org> napisał(a):
> >
> > On Fri, Jan 10, 2020 at 1:17 AM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> > >
> > > From: Bartosz Golaszewski <bgolaszewski@...libre.com>
> > >
> > > If building gconfig fails, a temporary gtk config file is left in the
> > > kconfig directory and is not ignored by git. Add an appropriate pattern
> > > to .gitignore.
> > >
> > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> > > ---
> > >  scripts/kconfig/.gitignore | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/scripts/kconfig/.gitignore b/scripts/kconfig/.gitignore
> > > index b5bf92f66d11..d22e6753397d 100644
> > > --- a/scripts/kconfig/.gitignore
> > > +++ b/scripts/kconfig/.gitignore
> > > @@ -3,6 +3,7 @@
> > >  #
> > >  *.moc
> > >  *conf-cfg
> > > +*conf-cfg.tmp
> >
> > I have no idea in which situation this pattern is left.
> >
> > Could you tell me the way to reproduce it?
>
> Sure:
>
> 1. Don't have gtk+ development files installed.
> 2. Run `make gconfig`.
> 3. Watch it fail with the following error message:
>
> ---
> $ make gconfig
> *
> * Unable to find the GTK+ installation. Please make sure that
> * the GTK+ 2.0 development package is correctly installed.
> * You need gtk+-2.0 gmodule-2.0 libglade-2.0
> *
> make[1]: *** [scripts/kconfig/Makefile:212: scripts/kconfig/gconf-cfg] Error 1
> make: *** [Makefile:568: gconfig] Error 2
> ---
>
> 4. See the file `gconf-cfg.tmp` under scripts/kconfig.
>
> Bart

Thanks for this info.

This seems a kbuild bug, so I fixed the root cause
instead of hiding the garbage files.

https://patchwork.kernel.org/patch/11326631/


-- 
Best Regards
Masahiro Yamada