linux-kernel - Re: [v3] coccinelle: semantic patch to check for inappropriate do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c64b6f61-f523-dc8a-2abc-b0e9a8cd2d98@web.de>
Date:   Sat, 11 Jan 2020 09:03:49 +0100
From:   Markus Elfring <Markus.Elfring@....de>
To:     Julia Lawall <julia.lawall@...ia.fr>,
        Wen Yang <wenyang@...ux.alibaba.com>, cocci@...teme.lip6.fr
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Matthias Männich <maennich@...gle.com>,
        Michal Marek <michal.lkml@...kovi.net>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [v3] coccinelle: semantic patch to check for inappropriate
 do_div() calls

>> Can the avoidance of duplicate source code (according to SmPL disjunctions)
>> trigger positive effects on run time characteristics and software maintenance?
>
> Markus.  Please stop asking this question.

This will not happen for a while.


> You are bothering people with this advice,

I present just another view.


> why don't _you_ figure out once and for all whether the change
> that you suggest has any "positive effects on the run time characteristics"?
> Hint: it will not.

* How much attention do you give to the software development principle
  "Don't repeat yourself"?

* Can the file size of a SmPL script matter a bit?


> Coccinelle has a pass that propagates disjunctions at the sub-statement level
> to the statement level.

This data processing can probably trigger further development considerations.

Regards,
Markus