linux-kernel - Re: [PATCH] tty: n_hdlc: fix build on SPARC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200112.000504.1994757840298424991.davem@davemloft.net>
Date:   Sun, 12 Jan 2020 00:05:04 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     rdunlap@...radead.org
Cc:     linux-kernel@...r.kernel.org, sparclinux@...r.kernel.org,
        akpm@...ux-foundation.org, gregkh@...uxfoundation.org,
        keescook@...omium.org, lkp@...el.com
Subject: Re: [PATCH] tty: n_hdlc: fix build on SPARC

From: Randy Dunlap <rdunlap@...radead.org>
Date: Mon, 30 Sep 2019 19:15:12 -0700

> From: Randy Dunlap <rdunlap@...radead.org>
> 
> Fix tty driver build on SPARC by not using __exitdata.
> It appears that SPARC does not support section .exit.data.
> 
> Fixes these build errors:
> 
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> `.exit.data' referenced in section `.exit.text' of drivers/tty/n_hdlc.o: defined in discarded section `.exit.data' of drivers/tty/n_hdlc.o
> 
> Reported-by: kbuild test robot <lkp@...el.com>
> Fixes: 063246641d4a ("format-security: move static strings to const")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>

I'll add an .exit.data to arch/sparc/kernel/vmlinux.lds.S to fix this.