[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200112001623.2121227-2-martin.blumenstingl@googlemail.com>
Date: Sun, 12 Jan 2020 01:16:21 +0100
From: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To: dri-devel@...ts.freedesktop.org, alyssa@...enzweig.io,
steven.price@....com, tomeu.vizoso@...labora.com, robh@...nel.org
Cc: linux-kernel@...r.kernel.org, daniel@...ll.ch, airlied@...ux.ie,
robin.murphy@....com, linux-amlogic@...ts.infradead.org,
linux-rockchip@...ts.infradead.org, sudeep.holla@....com,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Subject: [PATCH RFT v2 1/3] drm/panfrost: enable devfreq based the "operating-points-v2" property
Decouple the check to see whether we want to enable devfreq for the GPU
from dev_pm_opp_set_regulators(). This is preparation work for adding
back support for regulator control (which means we need to call
dev_pm_opp_set_regulators() before dev_pm_opp_of_add_table(), which
means having a check for "is devfreq enabled" that is not tied to
dev_pm_opp_of_add_table() makes things easier).
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
---
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
index 413987038fbf..1471588763ce 100644
--- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
+++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
@@ -5,6 +5,7 @@
#include <linux/platform_device.h>
#include <linux/pm_opp.h>
#include <linux/clk.h>
+#include <linux/property.h>
#include <linux/regulator/consumer.h>
#include "panfrost_device.h"
@@ -79,10 +80,12 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev)
struct devfreq *devfreq;
struct thermal_cooling_device *cooling;
- ret = dev_pm_opp_of_add_table(dev);
- if (ret == -ENODEV) /* Optional, continue without devfreq */
+ if (!device_property_present(dev, "operating-points-v2"))
+ /* Optional, continue without devfreq */
return 0;
- else if (ret)
+
+ ret = dev_pm_opp_of_add_table(dev);
+ if (ret)
return ret;
panfrost_devfreq_reset(pfdev);
--
2.24.1
Powered by blists - more mailing lists