linux-kernel - Re: BUG_ON hit in "reimplement path_mountpoint() with less magic" [Was: Re: linux-next: Tree for Jan 13]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200113192315.GS8904@ZenIV.linux.org.uk>
Date:   Mon, 13 Jan 2020 19:23:15 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: BUG_ON hit in "reimplement path_mountpoint() with less magic"
 [Was: Re: linux-next: Tree for Jan 13]

On Mon, Jan 13, 2020 at 01:27:34PM -0500, Jason A. Donenfeld wrote:
> Hi Al,
> 
> Your "reimplement path_mountpoint() with less magic" commit is causing
> oopses on the linux-next tests running on https://build.wireguard.com/ .
> Here's one such crash with debug symbols:

Check if that persists with the version currently in #fixes (commit
7a955b7363b8).  It ought to be fixed there; quick check is to look
at fs/namei.c:path_mountpoint() in your tree - it should read
	if (!err && (nd->flags & LOOKUP_RCU))
		err = unlazy_walk(nd);
not
	if (!err)
		err = unlazy_walk(nd);
as in the broken variant.