linux-kernel - Re: [PATCH v2] KVM: nVMX: vmread should not set rflags to specify success in case of #PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200113201103.GD2322@linux.intel.com>
Date:   Mon, 13 Jan 2020 12:11:04 -0800
From:   Sean Christopherson <sean.j.christopherson@...el.com>
To:     linmiaohe <linmiaohe@...wei.com>
Cc:     pbonzini@...hat.com, rkrcmar@...hat.com, vkuznets@...hat.com,
        wanpengli@...cent.com, jmattson@...gle.com, joro@...tes.org,
        tglx@...utronix.de, mingo@...hat.com, bp@...en8.de, hpa@...or.com,
        liran.alon@...cle.com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH v2] KVM: nVMX: vmread should not set rflags to specify
 success in case of #PF

On Mon, Jan 13, 2020 at 12:09:42PM -0800, Sean Christopherson wrote:
> On Sat, Dec 28, 2019 at 02:25:24PM +0800, linmiaohe wrote:
> > From: Miaohe Lin <linmiaohe@...wei.com>
> > 
> > In case writing to vmread destination operand result in a #PF, vmread
> > should not call nested_vmx_succeed() to set rflags to specify success.
> > Similar to as done in VMPTRST (See handle_vmptrst()).
> > 
> > Reviewed-by: Liran Alon <liran.alon@...cle.com>
> > Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> 
> Reviewed-by: Sean Christopherson <sean.j.christopherson@...el.com>

Gah, got trigger happy.  This could also have "Cc: stable@...r.kernel.org".
With that, my Reviewed-by stands :-).