linux-kernel - Re: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when not needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f35928f4e8f78be59617c0d49308001d92b314c7.camel@perches.com>
Date:   Sun, 12 Jan 2020 23:40:10 -0800
From:   Joe Perches <joe@...ches.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Akinobu Mita <akinobu.mita@...il.com>,
        linux-rtc@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: i2c/spi: Avoid inclusion of REGMAP support when
 not needed

On Mon, 2020-01-13 at 08:25 +0100, Geert Uytterhoeven wrote:
> Hi Joe,
> 
> On Mon, Jan 13, 2020 at 7:36 AM Joe Perches <joe@...ches.com> wrote:
> > On Sun, 2020-01-12 at 18:13 +0100, Geert Uytterhoeven wrote:
> > > Merely enabling I2C and RTC selects REGMAP_I2C and REGMAP_SPI, even when
> > > no driver needs it.  While the former can be moduler, the latter cannot,
> > > and thus becomes built-in.
> > > 
> > > Fix this by moving the select statements for REGMAP_I2C and REGMAP_SPI
> > > from the RTC_I2C_AND_SPI helper to the individual drivers that depend on
> > > it.
> > > 
> > > Note that the comment for RTC_I2C_AND_SPI refers to SND_SOC_I2C_AND_SPI
> > > for more information, but the latter does not select REGMAP_{I2C,SPI}
> > > itself, and defers that to the individual drivers, too.
> > > 
> > > Fixes: 080481f54ef62121 ("rtc: merge ds3232 and ds3234")
> > > Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> > > ---
> > > Joe: When merging addresses, scripts/get_maintainer.pl replaces
> > >      Alexandre's authoritative email address from MAINTAINERS by the
> > >      obsolete address in the SoB-line of the commit referred to by the
> > >      Fixes-line.
> > 
> > Hi Geert
> > 
> > What are you doing to get this changed output?
> 
> scripts/get_maintainer.pl
> 0001-rtc-i2c-spi-Avoid-inclusion-of-REGMAP-support-when-n.patch
> 
> > I get the same get_maintainer address output either way
> > with only with the 'blamed_fixes:' content added.
> 
> Thanks, I can confirm it's fixed in next-20200110.
> With v5.5-rc6, it still gives the old addresss.

Well, OK, get_maintainer is the same but there is a
different .mailmap in -next

$ git log --stat -p -1 94a250713
commit 94a25071301a898d8c603db2f05a0016eb7b7d28
Author: Alexandre Belloni <alexandre.belloni@...tlin.com>
Date:   Tue Dec 10 14:46:53 2019 +0100

    mailmap: Update email address for Alexandre Belloni
    
    Free Electrons is now Bootlin.
    
    Link: https://lore.kernel.org/r/20191210134653.2995661-1-alexandre.belloni@bootlin.com
    Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>