linux-kernel - Re: [PATCH] ubifs: Fix potentially out-of-bounds memory access inubifs_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <646354604.19725.1578904244502.JavaMail.zimbra@nod.at>
Date:   Mon, 13 Jan 2020 09:30:44 +0100 (CET)
From:   Richard Weinberger <richard@....at>
To:     liu song11 <liu.song11@....com.cn>
Cc:     Richard Weinberger <richard.weinberger@...il.com>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        jiang xuexin <jiang.xuexin@....com.cn>
Subject: Re: [PATCH] ubifs: Fix potentially out-of-bounds memory access
 inubifs_dump_node

----- Ursprüngliche Mail -----
> Although this will change a bit more, but the function of dumping data is
> retained,
> I will modify it as suggested and try to submit a patch, thanks.

Sure but the most common and important case is good then.
in fs/ubifs/file.c we use a fixed buffer size of UBIFS_MAX_DATA_NODE_SZ
to deal with data nodes. So, dumping is safe.

If we don't know the buffer size for minor cases, not a big deal.
Still better than giving up the feature completely.

Thanks,
//richard