linux-kernel - Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1578908504.20923.25.camel@mhfsdcap03>
Date:   Mon, 13 Jan 2020 17:41:44 +0800
From:   Yong Liang <yong.liang@...iatek.com>
To:     Nicolas Boichat <drinkcat@...omium.org>
CC:     Matthias Brugger <matthias.bgg@...il.com>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Devicetree List <devicetree@...r.kernel.org>,
        lkml <linux-kernel@...r.kernel.org>,
        "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "linux-watchdog@...r.kernel.org" <linux-watchdog@...r.kernel.org>,
        Jiaxin Yu (俞家鑫) 
        <Jiaxin.Yu@...iatek.com>,
        "Sj Huang (黃信璋)" 
        <sj.huang@...iatek.com>
Subject: Re: [PATCH v3 1/2] amr64: dts: modify mt8183.dtsi

On Mon, 2020-01-13 at 14:27 +0800, Nicolas Boichat wrote:
> +Jiaxin +Sj Huang
> 
> On Mon, Jan 13, 2020 at 12:44 PM Nicolas Boichat <drinkcat@...omium.org> wrote:
> >
> > On Fri, Jan 10, 2020 at 6:09 PM Matthias Brugger <matthias.bgg@...il.com> wrote:
> > > [snip]
> > > That's all a bit confusing, I thought we are fine to add the reset cells to
> > > infracfg as we have the resets defined in
> > > 64ebb57a3df6 ("clk: reset: Modify reset-controller driver")
> >
> > You're right, we're fine. But at least in theory, we should still have
> > the binding documentation that I linked above.
> >
> > I will try to pick up all the required patches, split them across
> > 8183/2712 and resend as one series.
> 
> Okay, summary of the patches, there are 2 series:
> 
> https://patchwork.kernel.org/patch/11311237/
> [1.1] [v3,1/2] amr64: dts: modify mt8183.dtsi
>   => Partially applied to Matthias' v5.5-next/dts64
>   => Other part depend on [1.2], needs to be applied
> https://patchwork.kernel.org/patch/11311241/
> [1.2] [v3,2/2] dt-bindings: mt8183: Add watchdog dt-binding
>   => Pending Guenter/Wim
> 
> https://patchwork.kernel.org/cover/11326757/
> [2.0] [PATCH v11 0/3] ASoC: mt8183: fix audio playback slowly after playback
> [2.1] [PATCH v11 1/3] dt-bindings: mediatek: mt8183: Add #reset-cells
>   => IMHO adding mt2712 compatible should be another patch
>   => Depends on [1.2]
>   => Tags should be all dropped
> [2.2] [PATCH v11 2/3] watchdog: mtk_wdt: mt8183: Add reset controller
>   => Issues about tags
> [2.3] [PATCH v11 3/3] watchdog: mtk_wdt: mt2712: Add reset controller
>   => Issues about tags
> 
> Jiaxin/Yong Liang/Matthias: Please let me know, I'm happy to pick up
> the patches, clean them up and resend them, if you think that helps.
> 
  [1.2] [v3,2/2] dt-bindings: mt8183: Add watchdog dt-binding
  -> It is no use, I will send 8183 in jiaxin's patch
     We want to send jiaxin's patch prioritily. So you can merge
jiaxin's patch firstly.
> 
> > > That's why I took this part from:
> > > https://lore.kernel.org/linux-mediatek/20191226093930.22413-1-yong.liang@mediatek.com/
> > >
> > > Please let me know if I'm wrong and I'll drop it.
> > >
> > > Regards,
> > > Matthias
> > >
> > > >>> 2. Add watchdog device node
> > > >
> > > > Can we have a patch with just this change instead, since you're
> > > > sending the binding with it.
> > > >
> > > >>>
> > > >>> Signed-off-by: yong.liang <yong.liang@...iatek.com>
> > > >>
> > > >> Tested-by: Nicolas Boichat <drinkcat@...omium.org>
> > > >>
> > > >>> ---
> > > >>>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 8 ++++++++
> > > >>>  1 file changed, 8 insertions(+)
> > > >>> [snip]