linux-kernel - Re: [Nouveau] [PATCH -next] drm/ttm: Remove set but not used variable 'mem'

Open Source and information security mailing list archives

Message-ID: <CACAvsv4LQAs_GAavgywod1ksxvKe5JE6FNGMnULbnJACJ280KQ@mail.gmail.com>
Date:   Mon, 13 Jan 2020 10:07:05 +1000
From:   Ben Skeggs <skeggsb@...il.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     Ben Skeggs <bskeggs@...hat.com>, Dave Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        ML nouveau <nouveau@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        ML dri-devel <dri-devel@...ts.freedesktop.org>
Subject: Re: [Nouveau] [PATCH -next] drm/ttm: Remove set but not used variable 'mem'

On Fri, 10 Jan 2020 at 17:32, YueHaibing <yuehaibing@...wei.com> wrote:
>
> drivers/gpu/drm/nouveau/nouveau_ttm.c: In function nouveau_vram_manager_new:
> drivers/gpu/drm/nouveau/nouveau_ttm.c:66:22: warning: variable mem set but not used [-Wunused-but-set-variable]
> drivers/gpu/drm/nouveau/nouveau_ttm.c: In function nouveau_gart_manager_new:
> drivers/gpu/drm/nouveau/nouveau_ttm.c:106:22: warning: variable mem set but not used [-Wunused-but-set-variable]
>
> They are not used any more, so remove it.
Thanks!

>
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  drivers/gpu/drm/nouveau/nouveau_ttm.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_ttm.c b/drivers/gpu/drm/nouveau/nouveau_ttm.c
> index 77a0c6a..7ca0a24 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_ttm.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_ttm.c
> @@ -63,14 +63,12 @@ nouveau_vram_manager_new(struct ttm_mem_type_manager *man,
>  {
>         struct nouveau_bo *nvbo = nouveau_bo(bo);
>         struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
> -       struct nouveau_mem *mem;
>         int ret;
>
>         if (drm->client.device.info.ram_size == 0)
>                 return -ENOMEM;
>
>         ret = nouveau_mem_new(&drm->master, nvbo->kind, nvbo->comp, reg);
> -       mem = nouveau_mem(reg);
>         if (ret)
>                 return ret;
>
> @@ -103,11 +101,9 @@ nouveau_gart_manager_new(struct ttm_mem_type_manager *man,
>  {
>         struct nouveau_bo *nvbo = nouveau_bo(bo);
>         struct nouveau_drm *drm = nouveau_bdev(bo->bdev);
> -       struct nouveau_mem *mem;
>         int ret;
>
>         ret = nouveau_mem_new(&drm->master, nvbo->kind, nvbo->comp, reg);
> -       mem = nouveau_mem(reg);
>         if (ret)
>                 return ret;
>
> --
> 2.7.4
>
>
> _______________________________________________
> Nouveau mailing list
> Nouveau@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/nouveau

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives