lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 13 Jan 2020 10:27:12 +0000 From: Robin Murphy <robin.murphy@....com> To: Heiko Stuebner <heiko@...ech.de>, Johan Jonker <jbx6244@...il.com> Cc: mark.rutland@....com, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org, robh+dt@...nel.org, linux-arm-kernel@...ts.infradead.org Subject: Re: [PATCH] arm64: dts: rockchip: add reg property to brcmf sub node On 13/01/2020 9:26 am, Heiko Stuebner wrote: > Hi Johan, > > Am Freitag, 10. Januar 2020, 16:40:24 CET schrieb Johan Jonker: >> Hi, >> >> Question for Heiko or rob+dt. >> Where would should #address-cells and #size-cells go in the dts or to the dtsi. >> In case they become required in a futhure rockchip-dw-mshc.yaml? >> ie. Should we patch all XXX rockchip,rk3288-dw-mshc nodes with them? > > I don't think it is a required property for the dw-mmc itself, as only > in special-cases do you need subnodes there. Like emmc and sd-cards > are completely probeable without needing further information and > only the wifi/bt chips _might_ need these. > > So I don't think that this is a property of the controller itself, but te > connected card - hence should stay in the board file. Indeed, and in general dtc already warns about those properties being present unnecessarily, e.g.: arch/arm64/boot/dts/rockchip/rk3399.dtsi:1812.27-1847.4: Warning (avoid_unnecessary_addr_size): /mipi@...68000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property Robin.
Powered by blists - more mailing lists