linux-kernel - Re: [PATCH] cpuidle: teo: bugfix in intervals[] array indexing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Jan 2020 11:44:10 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Ikjoon Jang <ikjn@...omium.org>
Cc:     Linux PM <linux-pm@...r.kernel.org>,
        "RafaelJ . Wysocki" <rafael.j.wysocki@...el.com>,
        DanielLezcano <daniel.lezcano@...aro.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cpuidle: teo: bugfix in intervals[] array indexing

On Fri, Jan 10, 2020 at 6:47 PM Ikjoon Jang <ikjn@...omium.org> wrote:
>
> Fix a simple bug in rotating array index.
>
> Signed-off-by: Ikjoon Jang <ikjn@...omium.org>
> ---
>  drivers/cpuidle/governors/teo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpuidle/governors/teo.c b/drivers/cpuidle/governors/teo.c
> index de7e706efd46..6deaaf5f05b5 100644
> --- a/drivers/cpuidle/governors/teo.c
> +++ b/drivers/cpuidle/governors/teo.c
> @@ -198,7 +198,7 @@ static void teo_update(struct cpuidle_driver *drv, struct cpuidle_device *dev)
>          * pattern detection.
>          */
>         cpu_data->intervals[cpu_data->interval_idx++] = measured_ns;
> -       if (cpu_data->interval_idx > INTERVALS)
> +       if (cpu_data->interval_idx >= INTERVALS)
>                 cpu_data->interval_idx = 0;
>  }
>
> --

Applied as a fix for 5,5 and "stable", thanks!