linux-kernel - Re: [PATCH v3 1/3] clocksource: davinci: only enable clockevents once tim34 is initialized

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 13 Jan 2020 17:26:42 +0530
From:   Sekhar Nori <nsekhar@...com>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>
CC:     Thomas Gleixner <tglx@...utronix.de>,
        David Lechner <david@...hnology.com>,
        Kevin Hilman <khilman@...nel.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH v3 1/3] clocksource: davinci: only enable clockevents once
 tim34 is initialized

Hi Daniel, Bart,

On 11/01/20 3:59 PM, Daniel Lezcano wrote:
> 
> 
> On Sat, 11 Jan 2020 at 11:20, Bartosz Golaszewski <brgl@...ev.pl
> <mailto:brgl@...ev.pl>> wrote:
> 
>     pt., 10 sty 2020 o 18:56 Daniel Lezcano <daniel.lezcano@...aro.org
>     <mailto:daniel.lezcano@...aro.org>> napisał(a):
>     >
>     > On 10/01/2020 18:16, Bartosz Golaszewski wrote:
>     > > From: Bartosz Golaszewski <bgolaszewski@...libre.com
>     <mailto:bgolaszewski@...libre.com>>
>     > >
>     > > The DM365 platform has a strange quirk (only present when using
>     ancient
>     > > u-boot - mainline u-boot v2013.01 and later works fine) where if we
>     > > enable the second half of the timer in periodic mode before we
>     do its
>     > > initialization - the time won't start flowing and we can't boot.
>     > >
>     > > When using more recent u-boot, we can enable the timer, then
>     reinitialize
>     > > it and all works fine.
>     > >
>     > > To work around this issue only enable clockevents once tim34 is
>     > > initialized i.e. move clockevents_config_and_register() below tim34
>     > > initialization.
>     > >
>     > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@...libre.com
>     <mailto:bgolaszewski@...libre.com>>
>     >
>     > Shall I take it through my tree?
>     >
> 
>     Not sure, I'd say Sekhar should take it through arm-soc together with
>     the latter two patches if he's ok with this. Let's wait for him to
>     respond.
> 
> 
> Just in case:
> Acked-by: Daniel Lezcano <daniel.lezcano@...aro.org
> <mailto:daniel.lezcano@...aro.org>>

I was able to test the series on all 6 DaVinci SoCs. I will send this
upstream with Daniel's ack.

Thanks,
Sekhar