linux-kernel - Re: [RFC PATCH 0/8] Rework READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c076476f-96c2-8a5a-117c-e5f709a9ebaf@de.ibm.com>
Date:   Mon, 13 Jan 2020 13:40:16 +0100
From:   Christian Borntraeger <borntraeger@...ibm.com>
To:     Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org
Cc:     linux-arch@...r.kernel.org, kernel-team@...roid.com,
        Michael Ellerman <mpe@...erman.id.au>,
        Peter Zijlstra <peterz@...radead.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Segher Boessenkool <segher@...nel.crashing.org>,
        Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [RFC PATCH 0/8] Rework READ_ONCE() to improve codegen



On 10.01.20 17:56, Will Deacon wrote:
> Hi all,
> 
> This is a follow-up RFC to the discussions we had on the mailing list at
> the end of last year:
> 
> https://lore.kernel.org/lkml/875zimp0ay.fsf@mpe.ellerman.id.au
> 
> Unfortunately, we didn't get a "silver bullet" solution out of that
> long thread, but I've tried to piece together some of the bits and
> pieces we discussed and I've ended up with this series, which does at
> least solve the pressing problem with the bitops for arm64.
> 
> The rough summary of the series is:
> 
>   * Drop the GCC 4.8 workarounds, so that READ_ONCE() is a
>     straightforward dereference of a cast-to-volatile pointer.
> 
>   * Require that the access is either 1, 2, 4 or 8 bytes in size
>     (even 32-bit architectures tend to use 8-byte accesses here).
> 
>   * Introduce __READ_ONCE() for tearing operations with no size
>     restriction.
> 
>   * Drop pointer qualifiers from scalar types, so that volatile scalars
>     don't generate horrible stack-spilling mess. This is pretty ugly,
>     but it's also mechanical and wrapped up in a macro.
> 
>   * Convert acquire/release accessors to perform the same qualifier
>     stripping.
> 
> I gave up trying to prevent READ_ONCE() on aggregates because it is
> pervasive, particularly within the mm/ layer on things like pmd_t.
> Thankfully, these don't tend to be volatile.
> 
> I have more patches in this area because I'm trying to move all the
> read_barrier_depends() magic into arch/alpha/, but I'm holding off until
> we agree on this part first.
> 
> Cheers,
> 
> Will
> 
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
> Cc: Segher Boessenkool <segher@...nel.crashing.org>
> Cc: Christian Borntraeger <borntraeger@...ibm.com>
> Cc: Luc Van Oostenryck <luc.vanoostenryck@...il.com>
> Cc: Arnd Bergmann <arnd@...db.de>

Looks sane on s390. I also checked that the problematic sequence in
arch/s390/kvm/gaccess.c is not miscompiled (the binary code for the
ipte_lock function is almost the same, just different addresses due
to a different start address.)

The kernel seems to get slighly larger though.
Mostly due to different inlining decisions it seems.
Total: Before=14133361, After=14135643, chg +0.02%