linux-kernel - Re: [PATCH RESEND] phy: exynos5-usbdrd: Calibrating makes sense only for USB2.0 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c5da6e3-d62e-9aa9-8c0c-e028c2c8c444@samsung.com>
Date:   Mon, 13 Jan 2020 15:02:04 +0100
From:   Marek Szyprowski <m.szyprowski@...sung.com>
To:     linux-usb@...r.kernel.org, linux-samsung-soc@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Kishon Vijay Abraham I <kishon@...com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Krzysztof Kozlowski <krzk@...nel.org>
Subject: Re: [PATCH RESEND] phy: exynos5-usbdrd: Calibrating makes sense
 only for USB2.0 PHY


On 13.12.2019 09:31, Marek Szyprowski wrote:
> PHY calibration is needed only for USB2.0 (UTMI) PHY, so skip calling
> calibration code when phy_calibrate() is called for USB3.0 (PIPE3) PHY.
>
> Fixes: d8c80bb3b55b ("phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800")
> Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>

gentle ping

> ---
>   drivers/phy/samsung/phy-exynos5-usbdrd.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/phy/samsung/phy-exynos5-usbdrd.c b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> index 646259bee909..f07edd80d2f3 100644
> --- a/drivers/phy/samsung/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/samsung/phy-exynos5-usbdrd.c
> @@ -714,7 +714,9 @@ static int exynos5_usbdrd_phy_calibrate(struct phy *phy)
>   	struct phy_usb_instance *inst = phy_get_drvdata(phy);
>   	struct exynos5_usbdrd_phy *phy_drd = to_usbdrd_phy(inst);
>   
> -	return exynos5420_usbdrd_phy_calibrate(phy_drd);
> +	if (inst->phy_cfg->id == EXYNOS5_DRDPHY_UTMI)
> +		return exynos5420_usbdrd_phy_calibrate(phy_drd);
> +	return 0;
>   }
>   
>   static const struct phy_ops exynos5_usbdrd_phy_ops = {

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland