linux-kernel - Re: [PATCH v1 2/3] PCI: Change pci_bus_distribute_available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200113141533.GJ2838@lahna.fi.intel.com>
Date:   Mon, 13 Jan 2020 16:15:33 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Logan Gunthorpe <logang@...tatee.com>
Subject: Re: [PATCH v1 2/3] PCI: Change
 pci_bus_distribute_available_resources() args to struct resource

On Mon, Jan 06, 2020 at 03:45:52PM +0000, Nicholas Johnson wrote:
> Change pci_bus_distribute_available_resources() arguments from
> resource_size_t to struct resource to add more information required to
> get the alignment correct for bridge windows with alignment >1M.
> 
> We require (size, alignment), instead of just (size) which is what is
> currently available. The change from resource_size_t to struct resource
> does just that.
> 
> Note that the struct resource arguments are passed by value and not by
> reference. We do not want to pass by reference and change the resource
> size of the parent bridge window. We only want the size information.
> 
> No functional changes.
> 
> Signed-off-by: Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>

Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>