linux-kernel - RE: [External] Re: [PATCH] selinux: remove redundant selinux_nlmsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <HK2PR03MB4418B5D2AB089629A1FFC8AF92350@HK2PR03MB4418.apcprd03.prod.outlook.com>
Date:   Mon, 13 Jan 2020 15:00:06 +0000
From:   Huaisheng HS1 Ye <yehs1@...ovo.com>
To:     Stephen Smalley <sds@...ho.nsa.gov>,
        "paul@...l-moore.com" <paul@...l-moore.com>,
        "eparis@...isplace.org" <eparis@...isplace.org>,
        "jmorris@...ei.org" <jmorris@...ei.org>,
        "serge@...lyn.com" <serge@...lyn.com>
CC:     Tzu ting Yu1 <tyu1@...ovo.com>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "selinux@...r.kernel.org" <selinux@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Huaisheng Ye <yehs2007@...o.com>
Subject: RE: [External]  Re: [PATCH] selinux: remove redundant
 selinux_nlmsg_perm


> -----Original Message-----
> From: Stephen Smalley <sds@...ho.nsa.gov>
> Sent: Monday, January 13, 2020 9:47 PM
> 
> On 1/12/20 10:42 AM, Huaisheng Ye wrote:
> > From: Huaisheng Ye <yehs1@...ovo.com>
> >
> > selinux_nlmsg_perm is used for only by selinux_netlink_send. Remove
> > the redundant function to simplify the code.
> >
> > Signed-off-by: Huaisheng Ye <yehs1@...ovo.com>
> 
> The patch itself seems fine but it looks like someone accidentally put pig= in
> the log message when they meant pid=; that can be fixed via a separate patch.
> 
> Acked-by: Stephen Smalley <sds@...ho.nsa.gov>

Thanks for the Acked-by.
Aha, yes it is. I will offer the patch v2 to fix this typo.

Cheers,
Huaisheng Ye