linux-kernel - Re: [PATCH] dt-bindings: pinctrl: intel: Update to use generic bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Jan 2020 11:38:28 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Rahul Tanwar <rahul.tanwar@...ux.intel.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        yixin zhu <yixin.zhu@...ux.intel.com>, qi-ming.wu@...el.com,
        cheol.yong.kim@...el.com
Subject: Re: [PATCH] dt-bindings: pinctrl: intel: Update to use generic bindings

On Wed, Dec 18, 2019 at 12:20 AM Rahul Tanwar
<rahul.tanwar@...ux.intel.com> wrote:
>
> Kernel 5.5 adds generic pin mux & cfg node schema. Update pinctrl bindings
> for LGM to use these newly added schemas. Also, rename filename to match
> the compatible string.
>
> Signed-off-by: Rahul Tanwar <rahul.tanwar@...ux.intel.com>
> ---
>  .../devicetree/bindings/pinctrl/intel,lgm-io.yaml  |  76 ++++++++++++++
>  .../bindings/pinctrl/intel,lgm-pinctrl.yaml        | 116 ---------------------
>  2 files changed, 76 insertions(+), 116 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml
>  delete mode 100644 Documentation/devicetree/bindings/pinctrl/intel,lgm-pinctrl.yaml

Pretty sure I've said on multiple occasions to run 'make
dt_binding_check'... Linux-next is broken by this (and others).

> diff --git a/Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml b/Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml
> new file mode 100644
> index 000000000000..a386fb520510
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/intel,lgm-io.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/bindings/pinctrl/intel,lgm-io.yaml#

Drop 'bindings' from the path.

> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intel Lightning Mountain SoC pinmux & GPIO controller binding
> +
> +maintainers:
> +  - Rahul Tanwar <rahul.tanwar@...ux.intel.com>
> +
> +description: |
> +  Pinmux & GPIO controller controls pin multiplexing & configuration including
> +  GPIO function selection & GPIO attributes configuration.
> +
> +allOf:
> +  - $ref: pincfg-node.yaml#
> +  - $ref: pinmux-node.yaml#

This 'allOf' is at the wrong level...

> +
> +properties:
> +  compatible:
> +    const: intel,lgm-io
> +
> +  reg:
> +    maxItems: 1
> +
> +# Client device subnode's properties
> +patternProperties:
> +  '-pins$':
> +    type: object

...It should be here.

> +    description:
> +      Pinctrl node's client devices use subnodes for desired pin configuration.
> +      Client device subnodes use below standard properties.
> +
> +    properties:
> +      function: true
> +      group: true
> +      pins: true
> +      pinmux: true
> +      bias-pull-up: true
> +      bias-pull-down: true
> +      drive-strength: true
> +      slew-rate: true
> +      drive-open-drain: true
> +      output-enable: true
> +
> +    required:
> +      - function
> +      - group
> +
> +    additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  # Pinmux controller node
> +  - |
> +    pinctrl: pinctrl@...80000 {
> +        compatible = "intel,lgm-io";
> +        reg = <0xe2880000 0x100000>;
> +
> +        uart0-pins {
> +             pins = <64>, /* UART_RX0 */
> +                    <65>; /* UART_TX0 */
> +             function = "CONSOLE_UART0";
> +             pinmux = <1>,
> +                      <1>;
> +             groups = "CONSOLE_UART0";

'groups' is not a defined property. Should be 'group'.

> +          };
> +    };
> +
> +...