linux-kernel - Re: [PATCH v2 1/2] platform/x86: Add support for Uncore frequency control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3fc777da692d107a75ad648de4be5bbfa927d2be.camel@intel.com>
Date:   Mon, 13 Jan 2020 18:03:02 +0000
From:   "Pandruvada, Srinivas" <srinivas.pandruvada@...el.com>
To:     "yu.chen.surf@...il.com" <yu.chen.surf@...il.com>
CC:     "andy@...radead.org" <andy@...radead.org>,
        "andy@...nel.org" <andy@...nel.org>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "dvhart@...radead.org" <dvhart@...radead.org>,
        "platform-driver-x86@...r.kernel.org" 
        <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] platform/x86: Add support for Uncore frequency
 control

Hi Chenyu,

Thanks for the pointing.

On Mon, 2020-01-13 at 15:00 +0800, Yu Chen wrote:
> Hi Srinivas,
> On Mon, Jan 13, 2020 at 11:59 AM Srinivas Pandruvada
> <srinivas.pandruvada@...ux.intel.com> wrote:
> > +
> > +/* Common function to set min/max ratios to be used by sysfs
> > callbacks */
> > +static int uncore_write_ratio(struct uncore_data *data, unsigned
> > int input,
> > +                             int set_max)
> > +{
> > +       int ret;
> > +       u64 cap;
> > +
> > +       mutex_lock(&uncore_lock);
> > +
> > +       input /= UNCORE_FREQ_KHZ_MULTIPLIER;
> > +       if (!input || input > 0x7F) {
> > +               ret = -EINVAL;
> > +               goto finish_write;
> > +       }
> > +
> > +       rdmsrl(MSR_UNCORE_RATIO_LIMIT, cap);
> Should it be rdmsrl_on_cpu()?
Yes. Fixed and sent update.

Thanks,
Srinivas

> 
> Thanks,
> Chenyu