linux-kernel - Re: [PATCH] USB: serial: opticon: fix control-message timeouts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200113182546.GF411698@kroah.com>
Date:   Mon, 13 Jan 2020 19:25:46 +0100
From:   Greg KH <greg@...ah.com>
To:     Johan Hovold <johan@...nel.org>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable <stable@...r.kernel.org>,
        Martin Jansen <martin.jansen@...icon.com>
Subject: Re: [PATCH] USB: serial: opticon: fix control-message timeouts

On Mon, Jan 13, 2020 at 06:22:13PM +0100, Johan Hovold wrote:
> The driver was issuing synchronous uninterruptible control requests
> without using a timeout. This could lead to the driver hanging
> on open() or tiocmset() due to a malfunctioning (or malicious) device
> until the device is physically disconnected.
> 
> The USB upper limit of five seconds per request should be more than
> enough.
> 
> Fixes: 309a057932ab ("USB: opticon: add rts and cts support")
> Cc: stable <stable@...r.kernel.org>     # 2.6.39
> Cc: Martin Jansen <martin.jansen@...icon.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>