linux-kernel - Re: linux-next: Tree for Jan 13 (drivers/base/test/property-entry-test.o)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.20.2001141612110.14991@dhcp-10-175-171-251.vpn.oracle.com>
Date:   Tue, 14 Jan 2020 16:14:22 +0000 (GMT)
From:   Alan Maguire <alan.maguire@...cle.com>
To:     Brendan Higgins <brendanhiggins@...gle.com>
cc:     Stephen Rothwell <sfr@...b.auug.org.au>,
        KUnit Development <kunit-dev@...glegroups.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Alan Maguire <alan.maguire@...cle.com>
Subject: Re: linux-next: Tree for Jan 13
 (drivers/base/test/property-entry-test.o)

On Mon, 13 Jan 2020, Brendan Higgins wrote:

> +KUnit Development
> +open list:KERNEL SELFTEST FRAMEWORK
> 
> On Mon, Jan 13, 2020 at 3:40 PM Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> >
> > Hi Randy,
> >
> > On Mon, 13 Jan 2020 14:59:54 -0800 Randy Dunlap <rdunlap@...radead.org> wrote:
> > >
> > > on i386:
> > >
> > > WARNING: modpost: missing MODULE_LICENSE() in drivers/base/test/property-entry-test.o
> > > see include/linux/module.h for more information
> >
> > Sorry, I missed that yesterday.
> >
> > Caused by commit
> >
> >   c032ace71c29 ("software node: add basic tests for property entries")
> >
> > from the pm tree interacting with commit
> >
> >   9fe124bf1b77 ("kunit: allow kunit to be loaded as a module")
> >
> > from the kunit-next tree.
> 
> Yes, the problem seems to be that the property-entry-test is turned on
> when CONFIG_KUNIT is y or m.
> 
> From drivers/base/test/Makefile:
> ...
> obj-$(CONFIG_KUNIT) += property-entry-test.o
> 
> It seems we can fix it just by adding the missing MODULE_LICENSE, but
> I think there is a bigger question of whether we should let people do
> this. Do we want to just let people have their tests run whenever
> CONFIG_KUNIT is enabled? I am inclined to think no. It should be
> possible for people to run their test and their test only.
> 

I agree completely, CONFIG_KUNIT is too big a switch I
think, aside from the merge issues caused here. I've posted
a patch which introduces a per-test-suite CONFIG option:

https://lore.kernel.org/lkml/1579018183-14879-1-git-send-email-alan.maguire@oracle.com/T/#u

Brendan, do let me know if you want me to amend it to add a Suggested-by 
from you (didn't want to add it without your permission). Thanks!

Alan