linux-kernel - Re: [PATCHv2-next 3/3] serial_core: Remove unused member in uart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1b3cccb0814ba4b0c99592715776ed48f343795.camel@perches.com>
Date:   Tue, 14 Jan 2020 09:36:09 -0800
From:   Joe Perches <joe@...ches.com>
To:     Dmitry Safonov <dima@...sta.com>, linux-kernel@...r.kernel.org
Cc:     Dmitry Safonov <0x7f454c46@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Iurii Zaikin <yzaikin@...gle.com>,
        Jiri Slaby <jslaby@...e.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Vasiliy Khoruzhick <vasilykh@...sta.com>,
        linux-serial@...r.kernel.org
Subject: Re: [PATCHv2-next 3/3] serial_core: Remove unused member in
 uart_port

On Tue, 2020-01-14 at 17:19 +0000, Dmitry Safonov wrote:
> It should remove the align-padding before @name.
[]
> diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h
[]
> @@ -247,7 +247,6 @@ struct uart_port {
>  
>  	unsigned char		hub6;			/* this should be in the 8250 driver */
>  	unsigned char		suspended;
> -	unsigned char		unused;

I suggest this not be applied as this is just to let
readers know that there is an unused 1 byte alignment
hole here that could be used for something else.