linux-kernel - Re: [PATCH] mm/gup.c: use is_vm_hugetlb_page() to check whether to follow huge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ec77382-900c-56b9-dcad-f8b24117b097@nvidia.com>
Date:   Tue, 14 Jan 2020 11:07:03 -0800
From:   Ralph Campbell <rcampbell@...dia.com>
To:     Wei Yang <richardw.yang@...ux.intel.com>,
        <akpm@...ux-foundation.org>
CC:     <linux-mm@...ck.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mm/gup.c: use is_vm_hugetlb_page() to check whether to
 follow huge


On 1/12/20 11:03 PM, Wei Yang wrote:
> No functional change, just leverage the helper function to improve
> readability as others.
> 
> Signed-off-by: Wei Yang <richardw.yang@...ux.intel.com>

I had thought about doing this same thing. :-)
Reviewed-by: Ralph Campbell <rcampbell@...dia.com>

> ---
>   mm/gup.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/gup.c b/mm/gup.c
> index 7646bf993b25..7705929cc920 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -323,7 +323,7 @@ static struct page *follow_pmd_mask(struct vm_area_struct *vma,
>   	pmdval = READ_ONCE(*pmd);
>   	if (pmd_none(pmdval))
>   		return no_page_table(vma, flags);
> -	if (pmd_huge(pmdval) && vma->vm_flags & VM_HUGETLB) {
> +	if (pmd_huge(pmdval) && is_vm_hugetlb_page(vma)) {
>   		page = follow_huge_pmd(mm, address, pmd, flags);
>   		if (page)
>   			return page;
> @@ -433,7 +433,7 @@ static struct page *follow_pud_mask(struct vm_area_struct *vma,
>   	pud = pud_offset(p4dp, address);
>   	if (pud_none(*pud))
>   		return no_page_table(vma, flags);
> -	if (pud_huge(*pud) && vma->vm_flags & VM_HUGETLB) {
> +	if (pud_huge(*pud) && is_vm_hugetlb_page(vma)) {
>   		page = follow_huge_pud(mm, address, pud, flags);
>   		if (page)
>   			return page;
>