linux-kernel - Re: [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1973062.CA44Rh9njY@kreacher>
Date:   Tue, 14 Jan 2020 23:43:53 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Alan Maguire <alan.maguire@...cle.com>
Cc:     brendanhiggins@...gle.com, gregkh@...uxfoundation.org,
        dmitry.torokhov@...il.com, sfr@...b.auug.org.au,
        linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
        linux-kselftest@...r.kernel.org, skhan@...uxfoundation.org
Subject: Re: [PATCH] software node: introduce CONFIG_KUNIT_DRIVER_PE_TEST

On Tuesday, January 14, 2020 5:45:56 PM CET Randy Dunlap wrote:
> On 1/14/20 8:42 AM, Alan Maguire wrote:
> > On Tue, 14 Jan 2020, Randy Dunlap wrote:
> > 
> >> Hi Alan,
> >>
> >> On 1/14/20 8:09 AM, Alan Maguire wrote:
> >>> currently the property entry kunit tests are built if CONFIG_KUNIT=y.
> >>> This will cause warnings when merged with the kunit tree that now
> >>> supports tristate CONFIG_KUNIT.  While the tests appear to compile
> >>> as a module, we get a warning about missing module license.
> >>>
> >>> It's better to have a per-test suite CONFIG variable so that
> >>> we can do selective building of kunit-based suites, and can
> >>> also avoid merge issues like this.
> >>>
> >>> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> >>
> >> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> >>
> > 
> > Apologies for missing you out here.
> >  
> >>> Fixes: c032ace71c29 ("software node: add basic tests for property entries")
> >>> Signed-off-by: Alan Maguire <alan.maguire@...cle.com>
> >>> ---
> >>>  drivers/base/test/Kconfig  | 3 +++
> >>>  drivers/base/test/Makefile | 2 +-
> >>>  2 files changed, 4 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/base/test/Kconfig b/drivers/base/test/Kconfig
> >>> index 86e85da..d29ae95 100644
> >>> --- a/drivers/base/test/Kconfig
> >>> +++ b/drivers/base/test/Kconfig
> >>> @@ -8,3 +8,6 @@ config TEST_ASYNC_DRIVER_PROBE
> >>>  	  The module name will be test_async_driver_probe.ko
> >>>  
> >>>  	  If unsure say N.
> >>> +config KUNIT_DRIVER_PE_TEST
> >>> +	bool "KUnit Tests for property entry API"
> >>> +	depends on KUNIT
> >>
> >> Why is this bool instead of tristate?
> >>
> > 
> > The support for building kunit and kunit tests as modules has not merged 
> > into linux-next yet, so if we set the option to tristate the build would
> > fail for allmodconfig builds.   Once it's merged we can revisit though; I 
> > should have mentioned this, thanks for reminding me!
> 
> Oh. I see.  Thanks.

Patch applied, thanks!