linux-kernel - Re: [PATCH] perf clang: Fix build with Clang 9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de47fdbb-58c3-119d-2cbd-2db992248a94@maciej.szmigiero.name>
Date:   Wed, 15 Jan 2020 00:18:18 +0100
From:   "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
To:     Arnaldo Carvalho de Melo <arnaldo.melo@...il.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Dennis Schridde <devurandom@....net>,
        Denis Pronin <dannftk@...dex.ru>,
        Naohiro Aota <naota@...sp.net>,
        clang-built-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf clang: Fix build with Clang 9

On 14.01.2020 23:20, Arnaldo Carvalho de Melo wrote:
> Em Sat, Dec 28, 2019 at 06:13:14PM +0100, Maciej S. Szmigiero escreveu:
>> LLVM D59377 (included in Clang 9) refactored Clang VFS construction a bit,
>> which broke perf clang build.
>> Let's fix it.
>>
>> Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>
>> Reviewed-by: Dennis Schridde <devurandom@....net>
>> ---
>>  tools/perf/util/c++/clang.cpp | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/tools/perf/util/c++/clang.cpp b/tools/perf/util/c++/clang.cpp
>> index fc361c3f8570..c8885dfa3667 100644
>> --- a/tools/perf/util/c++/clang.cpp
>> +++ b/tools/perf/util/c++/clang.cpp
>> @@ -71,7 +71,11 @@ getModuleFromSource(llvm::opt::ArgStringList CFlags,
>>  	CompilerInstance Clang;
>>  	Clang.createDiagnostics();
>>  
>> +#if CLANG_VERSION_MAJOR < 9
>>  	Clang.setVirtualFileSystem(&*VFS);
>> +#else
>> +	Clang.createFileManager(&*VFS);
>> +#endif
> 
> Building on ubuntu 19.10 fails, is this related? Or to the other patch? I
> haven't paid attention other than realizing its clang related.

Don't think so, these linker errors you posted look unrelated.

See the following Gentoo bugs for sample compile errors fixed by these
patches:
https://bugs.gentoo.org/695726
https://bugs.gentoo.org/678652

Maciej