linux-kernel - Re: [PATCH 4/7] builddeb: avoid invoking sub-shells where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNAR3fL-RQM412LJmJD6v81JTJ+s0A5vcS4O=Y_=kNO4DUA@mail.gmail.com>
Date:   Tue, 14 Jan 2020 17:04:09 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Ben Hutchings <ben@...adent.org.uk>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Riku Voipio <riku.voipio@...aro.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/7] builddeb: avoid invoking sub-shells where possible

Hi Ben,

On Tue, Jan 14, 2020 at 2:21 AM Ben Hutchings <ben@...adent.org.uk> wrote:
> > +(
> > +     cd $srctree
> > +     find . arch/$SRCARCH -maxdepth 1 -name Makefile\*
> > +     find include scripts -type f -o -type l
> > +     find arch/$SRCARCH -name module.lds -o -name Kbuild.platforms -o -name Platform
> > +     find arch/$SRCARCH -name include -type f
>
> This command is wrong.  We currently find all files under all
> directories named "include" under arch/$SRCARCH.  (arc, arm and xtensa
> have some per-platform include directories in additional to the per-
> architecture include directory.)
>
> > +
> > +     if [ -d arch/$SRCARCH/scripts ]; then
> > +             find arch/$SRCARCH/scripts -type f
> > +     fi
> > +) > debian/hdrsrcfiles
> > +
> > +{
> > +     if is_enabled CONFIG_STACK_VALIDATION; then
> > +             find tools/objtool -type f -executable
> > +     fi
> > +
> > +     find arch/$SRCARCH/include Module.symvers include scripts -type f
> > +
> > +     if is_enabled CONFIG_GCC_PLUGINS; then
> > +             find scripts/gcc-plugins -name \*.so -o -name gcc-common.h
> > +     fi
>
> This is reverting patch 1.
>
> Ben.

Thank you for catching these.

I made a mistake somehow
when I inserted the patch 1, and then
rebased the others on top of it.

I will fix it in v2.


-- 
Best Regards
Masahiro Yamada