linux-kernel - Re: [PATCH] parisc: Use proper printk format for resource_size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <82e79053-00bf-283e-458d-0b2711258585@gmx.de>
Date:   Tue, 14 Jan 2020 09:27:35 +0100
From:   Helge Deller <deller@....de>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        linux-parisc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] parisc: Use proper printk format for resource_size_t

On 03.01.20 17:39, Krzysztof Kozlowski wrote:
> resource_size_t should be printed with its own size-independent format
> to fix warnings when compiling on 64-bit platform (e.g. with
> COMPILE_TEST):
>
>     arch/parisc/kernel/drivers.c: In function 'print_parisc_device':
>     arch/parisc/kernel/drivers.c:892:9: warning:
>         format '%p' expects argument of type 'void *',
>         but argument 4 has type 'resource_size_t {aka unsigned int}' [-Wformat=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  arch/parisc/kernel/drivers.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/parisc/kernel/drivers.c b/arch/parisc/kernel/drivers.c
> index a6c9f49c6612..a154de424421 100644
> --- a/arch/parisc/kernel/drivers.c
> +++ b/arch/parisc/kernel/drivers.c
> @@ -889,8 +889,8 @@ static void print_parisc_device(struct parisc_device *dev)
>  	static int count;
>
>  	print_pa_hwpath(dev, hw_path);
> -	pr_info("%d. %s at 0x%px [%s] { %d, 0x%x, 0x%.3x, 0x%.5x }",
> -		++count, dev->name, (void*) dev->hpa.start, hw_path, dev->id.hw_type,
> +	pr_info("%d. %s at %pa[p] [%s] { %d, 0x%x, 0x%.3x, 0x%.5x }",

It needs to be    %pap   instead of   %pa[p].
The documentation in Documentation/core-api/printk-formats.rst is correct, but misleading.
I corrected & applied it.
Thanks!


Helge


> +		++count, dev->name, &(dev->hpa.start), hw_path, dev->id.hw_type,
>  		dev->id.hversion_rev, dev->id.hversion, dev->id.sversion);
>
>  	if (dev->num_addrs) {
>