linux-kernel - Re: [PATCH] ALSA: usb-audio: fix sync-ep altsetting sanity check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hmuaqfmyx.wl-tiwai@suse.de>
Date:   Tue, 14 Jan 2020 09:42:30 +0100
From:   Takashi Iwai <tiwai@...e.de>
To:     Johan Hovold <johan@...nel.org>
Cc:     Jaroslav Kysela <perex@...ex.cz>, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, stable <stable@...r.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: fix sync-ep altsetting sanity check

On Tue, 14 Jan 2020 09:39:53 +0100,
Johan Hovold wrote:
> 
> The altsetting sanity check in set_sync_ep_implicit_fb_quirk() was
> checking for there to be at least one altsetting but then went on to
> access the second one, which may not exist.
> 
> This could lead to random slab data being used to initialise the sync
> endpoint in snd_usb_add_endpoint().
> 
> Fixes: c75a8a7ae565 ("ALSA: snd-usb: add support for implicit feedback")
> Fixes: ca10a7ebdff1 ("ALSA: usb-audio: FT C400 sync playback EP to capture EP")
> Fixes: 5e35dc0338d8 ("ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204")
> Fixes: 17f08b0d9aaf ("ALSA: usb-audio: add implicit fb quirk for Axe-Fx II")
> Fixes: 103e9625647a ("ALSA: usb-audio: simplify set_sync_ep_implicit_fb_quirk")
> Cc: stable <stable@...r.kernel.org>     # 3.5
> Signed-off-by: Johan Hovold <johan@...nel.org>

Thanks, applied now.


Takashi